[llvm] [LV, VP]VP intrinsics support for the Loop Vectorizer (PR #76172)

Alexey Bataev via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 09:50:25 PST 2024


alexey-bataev wrote:

> The review on Phabricator is now available on the static archive: https://reviews.llvm.org/D99750
> 
> Went through @ayalz 's latest comments and shared the one that still seems pending/open. There was quite a lot to go over, so I might have missed some comments.
> 
> Also added some more comments inline. In terms of further refactoring for this patch, would be good to remove the dedicated EVLIncrement opcode now that #78113 landed, if possible.
> 
> The other larger pending suggestion is related to EVL handling in the recipes; I suggest to add a TODO and address this as follow-up, unless @ayalz prefers doing the refactoring first. I am planning to split up/refactor memory recipe soon now that address computation is already moved out.

Instruction::Add still does not work, crashes the compiler because this VPInstruction returns that it "does not use only first lane".

https://github.com/llvm/llvm-project/pull/76172


More information about the llvm-commits mailing list