[compiler-rt] [tsan] Lazily call 'personality' to minimize sandbox violations (PR #79334)

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 01:02:19 PST 2024


================
@@ -267,6 +267,14 @@ static void ReExecIfNeeded() {
   if (reexec) {
     // Don't check the address space since we're going to re-exec anyway.
   } else if (!CheckAndProtect(false, false, false)) {
+    // ASLR personality check.
+    // N.B. 'personality' is sometimes forbidden by sandboxes, so we only call
+    // this as a last resort (when the memory mapping is incompatible and TSan
+    // would fail anyway).
+    int old_personality = personality(0xffffffff);
----------------
dvyukov wrote:

If it would be only about bots, then I would say let's try to add it (perhaps with an additional comment).
But it will also fail on local developer `ninja check-sanitizer` runs, right?

https://github.com/llvm/llvm-project/pull/79334


More information about the llvm-commits mailing list