[llvm] [AMDGPU] Don't fix the scavenge slot at offset 0 (PR #79136)

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 04:37:45 PST 2024


rovka wrote:

> This means that we need to fully handle access by incrementing SP and decrementing after. That was broken at some point. Do we still hit the PEI logic to keep the scavenging slot as close to the incoming SP as possible?

I'm not sure I follow, can you please clarify what you have in mind? Since the change only affects entry and chain functions, there's no incoming SP and we should be accessing the stack (scavenge slot included) directly with offsets, not via SP. If something were wrong with the way PEI is handling the SP, wouldn't that affect non-entry functions instead?

https://github.com/llvm/llvm-project/pull/79136


More information about the llvm-commits mailing list