[llvm] [llvm-objdump][AMDGPU] Pass ELF ABIVersion through disassembler (PR #78907)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 01:14:02 PST 2024


jh7370 wrote:

> > Admittedly, its a bit ugly to pass the ABIVersion through onSymbolStart but I'm not sure what a better place for it would be.
> 
> I am indeed concerned about this. Can you place the version inside `AMDGPUDisassembler` instead?

+1. The ABIVersion should be constant for a given file, so it feels like it should be configured up front when configuring the disassembler (and therefore presumably stored somewhere inside the disassembler class).

https://github.com/llvm/llvm-project/pull/78907


More information about the llvm-commits mailing list