[llvm] [MachineFrameInfo] Refactoring with computeMaxcallFrameSize() (NFC) (PR #78001)

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 09:28:43 PST 2024


JonPsson1 wrote:


> You could probably set it in [lowerInlineAsm](https://github.com/llvm/llvm-project/blob/705d9273c5417e04dc542f0e46b90960c235c753/llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp#L215), where the ExtraFlags are computed.

Thanks - patch updated.

> 
> How is this change going to affect code that doesn't pass through isel? For instance if someone writes a MIR test and doesn't specify `adjustsStack` in the `frameInfo`?

Yeah - for MIR tests using inline-asms with alignstack, they would either have to be created with -stop-before= (to get the frameInfo correct), or adjustsStack would have to be specified manually. 

https://github.com/llvm/llvm-project/pull/78001


More information about the llvm-commits mailing list