[llvm] [workflows] Split pr-code-format into two parts to make it more secure (PR #78216)

Tobias Hieta via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 15 23:24:02 PST 2024


================
@@ -72,9 +58,17 @@ jobs:
         # explicitly in code-format-helper.py and not have to diff starting at
         # the merge base.
         run: |
-          python ./code-format-tools/llvm/utils/git/code-format-helper.py \
+          python ./llvm/utils/git/code-format-helper.py \
+            --write-comment-to-file \
             --token ${{ secrets.GITHUB_TOKEN }} \
             --issue-number $GITHUB_PR_NUMBER \
             --start-rev $(git merge-base $START_REV $END_REV) \
----------------
tru wrote:

Yeah I am a bit worried about this. It really needs some testing, it was quite difficult to get the right incantation that formats just what have changed, but as long as we test that we format the right things it should  be fine.

https://github.com/llvm/llvm-project/pull/78216


More information about the llvm-commits mailing list