[llvm] [AMDGPU] Do not preserve UniformityInfo (PR #76696)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 01:10:52 PST 2024


================
@@ -85,7 +85,6 @@ class AMDGPURewriteUndefForPHILegacy : public FunctionPass {
     AU.addRequired<DominatorTreeWrapperPass>();
 
     AU.addPreserved<DominatorTreeWrapperPass>();
-    AU.addPreserved<UniformityInfoWrapperPass>();
----------------
jayfoad wrote:

> Will anything break in a future change if this is re-added?

Unfortunately we have never had a good way to diagnose this problem (preserving an analysis but not one of its transitive dependencies). I did once look at adding something to the legacy pass manager to detect it early (when adding passes instead of when running them) but never finished it.

https://github.com/llvm/llvm-project/pull/76696


More information about the llvm-commits mailing list