[compiler-rt] [compiler-rt][test]Mark thinlto icp test as UNSUPPORTED on ppc. (PR #76008)

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 21:07:42 PST 2023


https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/76008

The test failure is about failed to build instrumented binary on ppc (https://lab.llvm.org/buildbot/#/builders/18/builds/13228). Not sure how to fix this for now. Mark the test unsupported.

```
RUN: at line 46: /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/build_gcc/./bin/clang  --driver-mode=g++  -m64  -ldl  -fprofile-generate -fuse-ld=lld -O2 lib.cpp main.cpp -o main
+ /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/build_gcc/./bin/clang --driver-mode=g++ -m64 -ldl -fprofile-generate -fuse-ld=lld -O2 lib.cpp main.cpp -o main
ld.lld: error: /lib/../lib64/Scrt1.o: ABI version 1 is not supported
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

>From e3bfecf57ff7440ed50b51114df0d726c0e16b61 Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Tue, 19 Dec 2023 20:57:56 -0800
Subject: [PATCH 1/3] [compiler-rt][test]Mark thinlto icp test as UNSUPPORTED.
 Test failed when building instrumented binary

---
 .../profile/instrprof-thinlto-indirect-call-promotion.cpp    | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index 08efa42167e94d..adba5b24253a42 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -13,8 +13,13 @@
 // - Generate ThinLTO summary file with LLVM bitcodes, and run `function-import` pass.
 // - Run `pgo-icall-prom` pass for the IR module which needs to import callees.
 
+
 // REQUIRES: windows || linux || darwin
 
+// The test failed on ppc when building the instrumented binary.
+// ld.lld: error: /lib/../lib64/Scrt1.o: ABI version 1 is not supported
+// UNSUPPORTED: ppc
+
 // This test and IR test llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
 // are complementary to each other; a compiler-rt test has better test coverage
 // on different platforms, and the IR test is less restrictive in terms of

>From 1b3a6b9d4e21e7355e086d2527b1a33835cba551 Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Tue, 19 Dec 2023 20:58:51 -0800
Subject: [PATCH 2/3] Revert "[compiler-rt][test]Mark thinlto icp test as
 UNSUPPORTED. Test failed when building instrumented binary"

This reverts commit e3bfecf57ff7440ed50b51114df0d726c0e16b61.
---
 .../profile/instrprof-thinlto-indirect-call-promotion.cpp    | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index adba5b24253a42..08efa42167e94d 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -13,13 +13,8 @@
 // - Generate ThinLTO summary file with LLVM bitcodes, and run `function-import` pass.
 // - Run `pgo-icall-prom` pass for the IR module which needs to import callees.
 
-
 // REQUIRES: windows || linux || darwin
 
-// The test failed on ppc when building the instrumented binary.
-// ld.lld: error: /lib/../lib64/Scrt1.o: ABI version 1 is not supported
-// UNSUPPORTED: ppc
-
 // This test and IR test llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
 // are complementary to each other; a compiler-rt test has better test coverage
 // on different platforms, and the IR test is less restrictive in terms of

>From d90c30a1e5de172ec3e994d74bd1f63f34cc1288 Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Tue, 19 Dec 2023 21:03:23 -0800
Subject: [PATCH 3/3] [compiler-rt][test]Mark thinlto icp test as UNSUPPORTED.
 Building instrumented binary fails

---
 .../profile/instrprof-thinlto-indirect-call-promotion.cpp     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index 08efa42167e94d..860c054f69e1a6 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -15,6 +15,10 @@
 
 // REQUIRES: windows || linux || darwin
 
+// The test failed on ppc when building the instrumented binary.
+// ld.lld: error: /lib/../lib64/Scrt1.o: ABI version 1 is not supported
+// UNSUPPORTED: ppc
+
 // This test and IR test llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
 // are complementary to each other; a compiler-rt test has better test coverage
 // on different platforms, and the IR test is less restrictive in terms of



More information about the llvm-commits mailing list