[llvm] 038871a - [llvm] Use StringRef::{starts,ends}_with (NFC)

[Kazu Hirata via llvm-commits]

Author: Kazu Hirata
Date: 2023-12-16T14:47:16-08:00
New Revision: 038871ae684b9cf47222bc0de666847f7294cab5

URL: https://github.com/llvm/llvm-project/commit/038871ae684b9cf47222bc0de666847f7294cab5
DIFF: https://github.com/llvm/llvm-project/commit/038871ae684b9cf47222bc0de666847f7294cab5.diff

LOG: [llvm] Use StringRef::{starts,ends}_with (NFC)

This patch replaces uses of StringRef::{starts,ends}with with
StringRef::{starts,ends}_with for consistency with
std::{string,string_view}::{starts,ends}_with in C++20.

I'm planning to deprecate and eventually remove
StringRef::{starts,ends}with.

Added: 
    

Modified: 
    llvm/lib/TargetParser/Host.cpp
    llvm/unittests/Support/ProgramTest.cpp
    llvm/unittests/Support/TypeNameTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/TargetParser/Host.cpp b/llvm/lib/TargetParser/Host.cpp
index e822da11ee85a5..e61fcb248faec2 100644
--- a/llvm/lib/TargetParser/Host.cpp
+++ b/llvm/lib/TargetParser/Host.cpp
@@ -1536,7 +1536,7 @@ StringRef sys::detail::getHostCPUNameForSPARC(StringRef ProcCpuinfoContent) {
   // Look for cpu line to determine cpu name
   StringRef Cpu;
   for (unsigned I = 0, E = Lines.size(); I != E; ++I) {
-    if (Lines[I].startswith("cpu")) {
+    if (Lines[I].starts_with("cpu")) {
       Cpu = Lines[I].substr(5).ltrim("\t :");
       break;
     }
@@ -1853,7 +1853,7 @@ bool sys::getHostCPUFeatures(StringMap<bool> &Features) {
 
   // Look for the CPU features.
   for (unsigned I = 0, E = Lines.size(); I != E; ++I)
-    if (Lines[I].startswith("Features")) {
+    if (Lines[I].starts_with("Features")) {
       Lines[I].split(CPUFeatures, ' ');
       break;
     }

diff  --git a/llvm/unittests/Support/ProgramTest.cpp b/llvm/unittests/Support/ProgramTest.cpp
index 91dbb57fbdeca6..2e2b1958b9ac9d 100644
--- a/llvm/unittests/Support/ProgramTest.cpp
+++ b/llvm/unittests/Support/ProgramTest.cpp
@@ -130,7 +130,7 @@ TEST_F(ProgramEnvTest, CreateProcessLongPath) {
   // prefix.
   sys::path::native(MyAbsExe, sys::path::Style::windows_backslash);
   std::string MyExe;
-  if (!StringRef(MyAbsExe).startswith("\\\\?\\"))
+  if (!StringRef(MyAbsExe).starts_with("\\\\?\\"))
     MyExe.append("\\\\?\\");
   MyExe.append(std::string(MyAbsExe.begin(), MyAbsExe.end()));
 

diff  --git a/llvm/unittests/Support/TypeNameTest.cpp b/llvm/unittests/Support/TypeNameTest.cpp
index e0d9ac5ee7e380..3550c626e9e67c 100644
--- a/llvm/unittests/Support/TypeNameTest.cpp
+++ b/llvm/unittests/Support/TypeNameTest.cpp
@@ -35,7 +35,7 @@ TEST(TypeNameTest, Names) {
 #ifdef __clang__
   EXPECT_TRUE(S2Name.ends_with("S2")) << S2Name.str();
 #else
-  EXPECT_TRUE(S2Name.endswith("::S2")) << S2Name.str();
+  EXPECT_TRUE(S2Name.ends_with("::S2")) << S2Name.str();
 #endif
 #else
   EXPECT_EQ("UNKNOWN_TYPE", S1Name);