[llvm] [Cygwin] Cygwin general (PR #74944)

[Fangrui Song via llvm-commits]

=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/74944 at github.com>


MaskRay wrote:

> Changes need a more elaborate explanation than this.
> 
> We shouldn't, in general, be moving platform specific code from `Windows/Process.inc` into the comon code in `Process.cpp`. I presume the context is that Cygwin builds generally are considered Unix, not Windows, and use `Unix/Process.inc`, while for this specific function, it needs to use Win32 API. Such context needs to be mentioned for reviewers to be able to make sense of the change.

Agree.

> I'm not sure what the cleanest/most acceptable way to do that would be though - @MaskRay?

It seems that cygwin should use the `LLVM_ON_UNIX` code path?
I feel that adding more cygwin stuff is worth a discussion on https://discourse.llvm.org/

@chapuni added some cygwin support long time ago and may know more about the history.


https://github.com/llvm/llvm-project/pull/74944