[clang] [llvm] [LLVM][IR] Replace ConstantInt's specialisation of getType() with getIntegerType(). (PR #75217)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 05:11:09 PST 2023


nikic wrote:

> Most all the recommended changes assume the code paths will work equally well for vector types as they do for scalar types. Can we be so sure this is the case? This is why I opted to keep the casting assertions with the exception of a few places where I could be sure the code path was clean.

I don't think any of those code paths would cause a silent miscompile with vectors, which is the only thing we have to be concerned about (if it just hits a different assertion, that's fine).

https://github.com/llvm/llvm-project/pull/75217


More information about the llvm-commits mailing list