[compiler-rt] [clang-tools-extra] [clang] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 19:41:29 PST 2023


================
@@ -1,39 +0,0 @@
-; Do setup work for all below tests: generate bitcode and combined index
----------------
teresajohnson wrote:

Without use of the raw profile, this test would not have caught the regression. If we think the new compiler-rt test is enough to catch this case in the future, then perhaps we don't need this LLVM test at all (there should already be some ICP tests). But if the compiler-rt test is not enough, because some people don't run those, then this should stay and use a raw profile as input.

https://github.com/llvm/llvm-project/pull/74008


More information about the llvm-commits mailing list