[llvm] [NFC][RemoveDIs] Add LocationType parameter to DPValue ctor (PR #74091)

Stephen Tozer via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 8 03:14:20 PST 2023


https://github.com/SLTozer approved this pull request.

SGTM, though although it might be a pain to implement, it might be better to have the LocationType argument be explicit - I've also got a patch to add static `DPValue *createDP[Assign|Declare|Value]()` functions though, so it might be better to leave the default so that we aren't rewriting all the `new DPValue` callsites twice.

https://github.com/llvm/llvm-project/pull/74091


More information about the llvm-commits mailing list