[clang-tools-extra] [clang] [llvm] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

[David Li via llvm-commits]

david-xl wrote:

> > > > David says the itanium remapper file was only used once during gcc to llvm transition, so not relevant here.
> > > 
> > > 
> > > I believe it was actually for the libstdc++ to libc++ transition (see https://reviews.llvm.org/D51247 and https://reviews.llvm.org/D51240).
> > > If it is broken we'll at least want to add a FIXME there.
> > 
> > 
> > Yes, I meant libstdc++ to libc++ transition. Why source line is this comment addressing? I take take a look the changes/comments there.
> 
> Sorry for the misinformation, and thanks for the Phab links.
> 
> I think the itanium remapper needs a `:` -> `;` update (going to update this PR and related tests), since (for local-linkage functions) the function name used to look up profiles should use `;` delimiter.



> > > > David says the itanium remapper file was only used once during gcc to llvm transition, so not relevant here.
> > > 
> > > 
> > > I believe it was actually for the libstdc++ to libc++ transition (see https://reviews.llvm.org/D51247 and https://reviews.llvm.org/D51240).
> > > If it is broken we'll at least want to add a FIXME there.
> > 
> > 
> > Yes, I meant libstdc++ to libc++ transition. Why source line is this comment addressing? I take take a look the changes/comments there.
> 
> Sorry for the misinformation, and thanks for the Phab links.
> 
> I think the itanium remapper needs a `:` -> `;` update (going to update this PR and related tests), since (for local-linkage functions) the function name used to look up profiles should use `;` delimiter.

The remapper is not aware of any internal symbol mangling scheme, so those entires won't be tracked by it. In other words, there is no need to change anything there, I think.

https://github.com/llvm/llvm-project/pull/74008