[llvm] code-format: Improve the code-format-helper to be able to run as a git hook (PR #73957)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 13:09:55 PST 2023


================
@@ -63,17 +99,16 @@ def pr_comment_text_for_diff(self, diff: str) -> str:
 </details>
 """
 
-    def find_comment(
-        self, pr: PullRequest.PullRequest
-    ) -> IssueComment.IssueComment | None:
+    def find_comment(self, pr: any) -> any:
----------------
boomanaiden154 wrote:

It would be nice if we could maintain the type annotations here even though we don't want to import `github` when running as a hook. Probably would require some refactoring that can be left for future work though. Maybe leave a todo?

https://github.com/llvm/llvm-project/pull/73957


More information about the llvm-commits mailing list