[llvm] 6ed7a8e - [AMDGPU] Remove s_subvector_loop_begin/end for GFX12 (#74451)

via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 02:11:32 PST 2023


Author: Jay Foad
Date: 2023-12-06T10:11:28Z
New Revision: 6ed7a8eae65153fbbc1f42139074dcbcab833e81

URL: https://github.com/llvm/llvm-project/commit/6ed7a8eae65153fbbc1f42139074dcbcab833e81
DIFF: https://github.com/llvm/llvm-project/commit/6ed7a8eae65153fbbc1f42139074dcbcab833e81.diff

LOG: [AMDGPU] Remove s_subvector_loop_begin/end for GFX12 (#74451)

Added: 
    llvm/test/MC/AMDGPU/gfx12_unsupported.s

Modified: 
    llvm/lib/Target/AMDGPU/SOPInstructions.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SOPInstructions.td b/llvm/lib/Target/AMDGPU/SOPInstructions.td
index bfde97735bb20..9ff64968ef01b 100644
--- a/llvm/lib/Target/AMDGPU/SOPInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SOPInstructions.td
@@ -1100,10 +1100,14 @@ let SubtargetPredicate = isGFX10Plus in {
       "$simm16"> {
     let has_sdst = 0;
   }
+} // End SubtargetPredicate = isGFX10Plus
 
+let SubtargetPredicate = isGFX10GFX11 in {
   def S_SUBVECTOR_LOOP_BEGIN : SOPK_32_BR<"s_subvector_loop_begin">;
   def S_SUBVECTOR_LOOP_END   : SOPK_32_BR<"s_subvector_loop_end">;
+} // End SubtargetPredicate = isGFX10GFX11
 
+let SubtargetPredicate = isGFX10Plus in {
   def S_WAITCNT_VSCNT   : SOPK_WAITCNT<"s_waitcnt_vscnt">;
   def S_WAITCNT_VMCNT   : SOPK_WAITCNT<"s_waitcnt_vmcnt">;
   def S_WAITCNT_EXPCNT  : SOPK_WAITCNT<"s_waitcnt_expcnt">;

diff  --git a/llvm/test/MC/AMDGPU/gfx12_unsupported.s b/llvm/test/MC/AMDGPU/gfx12_unsupported.s
new file mode 100644
index 0000000000000..c9eb29c18a1a6
--- /dev/null
+++ b/llvm/test/MC/AMDGPU/gfx12_unsupported.s
@@ -0,0 +1,11 @@
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1200 %s 2>&1 | FileCheck --implicit-check-not=error: %s
+
+//===----------------------------------------------------------------------===//
+// Unsupported instructions.
+//===----------------------------------------------------------------------===//
+
+s_subvector_loop_begin s0, 0x1234
+// CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: instruction not supported on this GPU
+
+s_subvector_loop_end s0, 0x1234
+// CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: instruction not supported on this GPU


        


More information about the llvm-commits mailing list