[llvm] DAG: Fix chain mismanagement in SoftenFloatRes_FP_EXTEND (PR #74558)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 20:53:32 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 124b4ab85af254b9e8b6e466417d568fc50a25b2 1b598cdabbb05ae361a9ee018c33868efd022c07 -- llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
index 887670fb6b..ad44547055 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
@@ -3850,8 +3850,7 @@ void DAGTypeLegalizer::ExpandIntRes_LOAD(LoadSDNode *N,
     SDVTList VTs = DAG.getVTList(VT, MVT::i1, MVT::Other);
     SDValue Zero = DAG.getConstant(0, dl, VT);
     SDValue Swap = DAG.getAtomicCmpSwap(
-        ISD::ATOMIC_CMP_SWAP_WITH_SUCCESS, dl,
-        VT, VTs, N->getOperand(0),
+        ISD::ATOMIC_CMP_SWAP_WITH_SUCCESS, dl, VT, VTs, N->getOperand(0),
         N->getOperand(1), Zero, Zero, N->getMemOperand());
     ReplaceValueWith(SDValue(N, 0), Swap.getValue(0));
     ReplaceValueWith(SDValue(N, 1), Swap.getValue(2));
@@ -5414,11 +5413,9 @@ SDValue DAGTypeLegalizer::ExpandIntOp_STORE(StoreSDNode *N, unsigned OpNo) {
   if (N->isAtomic()) {
     // It's typical to have larger CAS than atomic store instructions.
     SDLoc dl(N);
-    SDValue Swap = DAG.getAtomic(ISD::ATOMIC_SWAP, dl,
-                                 N->getMemoryVT(),
-                                 N->getOperand(0), N->getOperand(2),
-                                 N->getOperand(1),
-                                 N->getMemOperand());
+    SDValue Swap =
+        DAG.getAtomic(ISD::ATOMIC_SWAP, dl, N->getMemoryVT(), N->getOperand(0),
+                      N->getOperand(2), N->getOperand(1), N->getMemOperand());
     return Swap.getValue(1);
   }
   if (ISD::isNormalStore(N))

``````````

</details>


https://github.com/llvm/llvm-project/pull/74558


More information about the llvm-commits mailing list