[llvm] [RemoveDIs] Update Coroutine passes to handle DPValues (PR #74480)

Felipe de Azevedo Piovezan via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 10:49:26 PST 2023


================
@@ -726,11 +726,14 @@ static void replaceSwiftErrorOps(Function &F, coro::Shape &Shape,
 
 /// Returns all DbgVariableIntrinsic in F.
 static SmallVector<DbgVariableIntrinsic *, 8>
-collectDbgVariableIntrinsics(Function &F) {
+collectDbgVariableIntrinsics(Function &F, SmallVector<DPValue *> &DPValues) {
----------------
felipepiovezan wrote:

It feels wrong to have an in parameter and a return type that are virtually the same thing.
I believe we should express this at the API more clearly by returning a pair of vectors, or make two separate functions

https://github.com/llvm/llvm-project/pull/74480


More information about the llvm-commits mailing list