[llvm] [MsgPack] Return an Error instead of bool from readFromBlob (PR #74357)

Scott Linder via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 12:48:16 PST 2023


================
@@ -5964,7 +5965,9 @@ template <class ELFT> void GNUELFDumper<ELFT>::printNotes() {
       const AMDGPUNote N = getAMDGPUNote<ELFT>(Type, Descriptor);
       if (!N.Type.empty()) {
         OS << "    " << N.Type << ":\n        " << N.Value << '\n';
-        return Error::success();
+        // Fallthrough to printing the description data blob on error.
----------------
slinder1 wrote:

Nit: I would expect the comment to come after the `if` which tests for the inverse case

https://github.com/llvm/llvm-project/pull/74357


More information about the llvm-commits mailing list