[llvm] [InstrRef][nfc] Remove usage of unique_ptrs of arrays (PR #74203)

[Felipe de Azevedo Piovezan via llvm-commits]

================
@@ -1200,21 +1200,21 @@ class InstrRefBasedLDV : public LDVImpl {
   /// exists, otherwise returns std::nullopt.
   std::optional<ValueIDNum> getValueForInstrRef(unsigned InstNo, unsigned OpNo,
                                                 MachineInstr &MI,
-                                                const ValueTable *MLiveOuts,
-                                                const ValueTable *MLiveIns);
+                                                const FuncValueTable *MLiveOuts,
+                                                const FuncValueTable *MLiveIns);
----------------
felipepiovezan wrote:

The challenge here is that there are code paths that pass a nullptr, because it reuses some functions to "visit" the code multiple times, and some of those don't need the map.

I really want to remove pointers that should be references, but because this would involve non-mechanical changes, I opted to leave that out of this patch. Does that seem reasonable?

https://github.com/llvm/llvm-project/pull/74203