[llvm] [DebugInfo][RemoveDIs] Support maintaining DPValues in CodeGenPrepare (PR #73660)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 03:32:58 PST 2023


================
@@ -8371,8 +8427,10 @@ bool CodeGenPrepare::placeDbgValues(Function &F) {
   for (BasicBlock &BB : F) {
     for (Instruction &Insn : llvm::make_early_inc_range(BB)) {
       DbgValueInst *DVI = dyn_cast<DbgValueInst>(&Insn);
-      if (!DVI)
+      if (!DVI) {
+        MadeChange |= placeDPValues(Insn, DT);
----------------
OCHyams wrote:

Shouldn't `placeDPValues` be placed before that `if (!DVI)` check, because a `DbgValueInst` can have `DPValues` attached. It's possibly an error if we have both DP- and dbg-values, so maybe it doesn't matter.

https://github.com/llvm/llvm-project/pull/73660


More information about the llvm-commits mailing list