[llvm] Fix #65890: Update the bot message to use github pull requests (PR #65914)

Danny Mösch via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 26 07:26:19 PST 2023


https://github.com/SimplyDanny updated https://github.com/llvm/llvm-project/pull/65914

>From 4b9ce8711219742f1faceffd0c92dac0b08ee780 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka <yerimyah1 at gmail.com>
Date: Sun, 10 Sep 2023 22:39:18 +0100
Subject: [PATCH 1/5] Fix #65890: Update the bot message to use github pull
 requests

---
 llvm/utils/git/github-automation.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index d9d1f9c7dc7ca86..626355c84863040 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -24,17 +24,15 @@
 
 This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
 
-  1) Assign the issue to you.
+  1) In the comments of the issue, request for it to be assigned to you.
   2) Fix the issue locally.
   3) [Run the test suite](https://llvm.org/docs/TestingGuide.html#unit-and-regression-tests) locally.
     3.1) Remember that the subdirectories under `test/` create fine-grained testing targets, so you can
          e.g. use `make check-clang-ast` to only run Clang's AST tests.
   4) Create a `git` commit
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
-  6) Submit the patch to [Phabricator](https://reviews.llvm.org/).
-    6.1) Detailed instructions can be found [here](https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
-
-For more instructions on how to submit a patch to LLVM, see our [documentation](https://llvm.org/docs/Contributing.html).
+  6) Submit the pull request in the [github repository](https://github.com/llvm/llvm-project/pulls).
+    6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request)
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.
 """

>From 6e8ff9247434605795e741d958045aec43671e23 Mon Sep 17 00:00:00 2001
From: Da-Viper <57949090+Da-Viper at users.noreply.github.com>
Date: Tue, 3 Oct 2023 20:25:41 +0100
Subject: [PATCH 2/5] Update llvm/utils/git/github-automation.py
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Danny Mösch <danny.moesch at icloud.com>
---
 llvm/utils/git/github-automation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 626355c84863040..6d3c15e9967020c 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -31,7 +31,7 @@
          e.g. use `make check-clang-ast` to only run Clang's AST tests.
   4) Create a `git` commit
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
-  6) Submit the pull request in the [github repository](https://github.com/llvm/llvm-project/pulls).
+  6) Open a pull request to the [upstream repository](https://github.com/llvm/llvm-project/pulls) on GitHub.
     6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request)
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

>From d1c63e0292181b6705c1e464e0e61e66b7192417 Mon Sep 17 00:00:00 2001
From: Da-Viper <57949090+Da-Viper at users.noreply.github.com>
Date: Tue, 3 Oct 2023 20:25:49 +0100
Subject: [PATCH 3/5] Update llvm/utils/git/github-automation.py
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Danny Mösch <danny.moesch at icloud.com>
---
 llvm/utils/git/github-automation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 6d3c15e9967020c..dc377993794eb6f 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -32,7 +32,7 @@
   4) Create a `git` commit
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
   6) Open a pull request to the [upstream repository](https://github.com/llvm/llvm-project/pulls) on GitHub.
-    6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request)
+    6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.
 """

>From 1ad529a5f52201e89bb1ffe1a150f4725442fee2 Mon Sep 17 00:00:00 2001
From: Da-Viper <57949090+Da-Viper at users.noreply.github.com>
Date: Tue, 3 Oct 2023 20:26:48 +0100
Subject: [PATCH 4/5] Update llvm/utils/git/github-automation.py
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Danny Mösch <danny.moesch at icloud.com>
---
 llvm/utils/git/github-automation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index dc377993794eb6f..2c7c243bd9047c5 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -29,7 +29,7 @@
   3) [Run the test suite](https://llvm.org/docs/TestingGuide.html#unit-and-regression-tests) locally.
     3.1) Remember that the subdirectories under `test/` create fine-grained testing targets, so you can
          e.g. use `make check-clang-ast` to only run Clang's AST tests.
-  4) Create a `git` commit
+  4) Create a Git commit.
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
   6) Open a pull request to the [upstream repository](https://github.com/llvm/llvm-project/pulls) on GitHub.
     6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).

>From ec9eea9fcb5cd361d3bb69112bfa1f314f51be5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?= <danny.moesch at icloud.com>
Date: Tue, 3 Oct 2023 23:30:35 +0200
Subject: [PATCH 5/5] Add and update hyperlinks

---
 llvm/utils/git/github-automation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 2c7c243bd9047c5..d8adb4650e525e2 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -31,7 +31,7 @@
          e.g. use `make check-clang-ast` to only run Clang's AST tests.
   4) Create a Git commit.
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
-  6) Open a pull request to the [upstream repository](https://github.com/llvm/llvm-project/pulls) on GitHub.
+  6) Open a [pull request](https://github.com/llvm/llvm-project/pulls) to the [upstream repository](https://github.com/llvm/llvm-project) on GitHub.
     6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.



More information about the llvm-commits mailing list