[llvm] Fix mayStore flag of PUSH instructions for MSP430 (PR #73377)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 24 21:31:37 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-msp430

Author: Yida Zhang (zyd2001)

<details>
<summary>Changes</summary>

A bug in MSP430InstrInfo.td.

---
Full diff: https://github.com/llvm/llvm-project/pull/73377.diff


1 Files Affected:

- (modified) llvm/lib/Target/MSP430/MSP430InstrInfo.td (+2-1) 


``````````diff
diff --git a/llvm/lib/Target/MSP430/MSP430InstrInfo.td b/llvm/lib/Target/MSP430/MSP430InstrInfo.td
index 0ff9763e4c93e18..714a5d4f5116554 100644
--- a/llvm/lib/Target/MSP430/MSP430InstrInfo.td
+++ b/llvm/lib/Target/MSP430/MSP430InstrInfo.td
@@ -305,12 +305,13 @@ def POP16r   : IForm16<0b0100, DstReg, SrcPostInc, 2,
   let rs = 1;
 }
 
-let mayStore = 1 in
+let mayStore = 1 in {
 def PUSH8r :  II8r<0b100, (outs), (ins GR8:$rs), "push.b\t$rs", []>;
 def PUSH16r : II16r<0b100, (outs), (ins GR16:$rs), "push\t$rs", []>;
 def PUSH16c : II16c<0b100, (outs), (ins cg16imm:$imm), "push\t$imm", []>;
 def PUSH16i : II16i<0b100, (outs), (ins i16imm:$imm), "push\t$imm", []>;
 }
+}
 
 //===----------------------------------------------------------------------===//
 // Move Instructions

``````````

</details>


https://github.com/llvm/llvm-project/pull/73377


More information about the llvm-commits mailing list