[llvm] [AMDGPU][SIInsertWaitcnts] Do not add s_waitcnt when the counters are known to be 0 already (PR #72830)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 06:38:22 PST 2023


Juan Manuel MARTINEZ =?utf-8?q?CAAMAÑO?= <juamarti at amd.com>,pvanhout
 <pierre.vanhoutryve at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/72830 at github.com>


jayfoad wrote:

> > > Original patch by @jmmartinez : #65735
> > 
> > 
> > I had a bunch of outstanding comments on that PR.
> 
> Aren't they all addressed, with the exception of the added `const` in SIInsertWaitCnt (which i'm going to remove) and the extra waitcnt mystery which I am looking into right now?

I don't know because I can't easily see what has changed. I'll try to take a fresh look soon.

https://github.com/llvm/llvm-project/pull/72830


More information about the llvm-commits mailing list