[llvm] [llvm-objdump] Fix lma display issue for non-bss sections (PR #72141)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 15:24:10 PST 2023


================
@@ -163,6 +163,49 @@ static inline Error defaultWarningHandler(const Twine &Msg) {
   return createError(Msg);
 }
 
+template <class ELFT>
+static bool checkOffsets(const typename ELFT::Phdr &Phdr,
----------------
MaskRay wrote:

Somewhat. The `static` makes the instantiated functions internal linkage, so you can have another template of the same mangling without ODR violation concern, but that's probably not a good idea anyway.

Dropping static will be better and enable linker duplicate elimination.

https://github.com/llvm/llvm-project/pull/72141


More information about the llvm-commits mailing list