[PATCH] D159354: [SROA] Limit the number of allowed slices when trying to split allocas

[Dhruv Chawla via Phabricator via llvm-commits]

0xdc03 added a comment.

In D159354#4656343 <https://reviews.llvm.org/D159354#4656343>, @alex-t wrote:

> This change breaks the AMDGPU backend performance. It causes the 85% performance drop in certain rocBLAS benchmarks.
> The approach itself seems weird to me. You'd better add a target hook to let the target decide about the thresholds instead of deciding for others.

This is also being discussed over at https://github.com/llvm/llvm-project/issues/69785, see specifically @nikic's comment <https://github.com/llvm/llvm-project/issues/69785#issuecomment-1773714904>. If its causing issues for too many users, then it may be a good idea to revert for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159354/new/

https://reviews.llvm.org/D159354