[llvm] [mlir] Shard the public llvm-config.h in multiple files (NFC) (PR #71273)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 18:49:48 PST 2023


joker-eph wrote:

> Adding new files for new options and splitting defines across a bunch of files is messy and will incur maintenance as people have a whole bunch of files floating around.

I don't quite get what you mean: what are "floating" files? I'm trying to picture it, but it's very fuzzy, I prompted StableDiffusion to get help ;)

![download](https://github.com/llvm/llvm-project/assets/3372300/de09ef3c-aca0-4cbd-a0ef-286570306cc0)

> This is a lot of complexity

Sorry but I see zero added complexity really right now. The whole thing seems just to me to be a cleaner software structure where you include what you need (include llvm-config-version.h for the VERSION* macros). Not clear why the current "monolithic blog" would be less messy and less complex?

https://github.com/llvm/llvm-project/pull/71273


More information about the llvm-commits mailing list