[llvm] [llvm-symbolizer] restore --[no-]use-symbol-table option (PR #71008)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 08:56:27 PST 2023


dwblaikie wrote:

> This PR doesn't create new breakage by itself. Since https://reviews.llvm.org/D83530, we are using --no-feature instead of --feature=false. I'm following this convention.

Yeah, just seems like a weird situation overall. No particular notes now, though. 

I think we usually test from assembly (have the test assemble it with `llvm-mc`) rather than checked in object files - could you update this test to work that way? (leaving the source code and compilation command line as a comment in the asm file would be useful too, though). @jh7370 to confirm.

https://github.com/llvm/llvm-project/pull/71008


More information about the llvm-commits mailing list