[lld] [LLD] Tombstone LocalTU entry in .debug_names (PR #70701)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 5 16:48:48 PST 2023


================
@@ -917,8 +925,7 @@ void InputSection::relocateNonAlloc(uint8_t *buf, ArrayRef<RelTy> rels) {
     if (expr == R_NONE)
       continue;
 
-    if (tombstone ||
-        (isDebug && (type == target.symbolicRel || expr == R_DTPREL))) {
+    if (tombstoneValueToUse) {
----------------
MaskRay wrote:

I think
`if (!sym.getOutputSection() || (ds && ds->folded && !isDebugLine))` should be the outer `if` and the tombstone logic should be the inner `if`.

https://github.com/llvm/llvm-project/pull/70701


More information about the llvm-commits mailing list