[lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 10:50:23 PDT 2023


JDevlieghere wrote:

> Yes, that specific kind of refactoring seemed like a good idea, but given that this is my first real foray into the LLDB space, I didn't want to bite off that much work to start with. 

I'd be happy to help with that and I'm sure @clayborg wouldn't mind providing guidance in this space. 

> Once I've got the full DEBUGINFOD capabilities plumbed, refactoring it out into a SymbolServer plug-in makes lots of sense.

That's fine if the new code can be more self contained. This patch is adding things like a `HTTPClient` to the debugger or a dependency on `Debuginfod.h` in Target. I don't think either of those things belong there. At the very least should be abstracted behind `LocateSymbol`. All its functions are static which makes that hard, which is why I suggested symbol server plugin. Maybe as an intermediate step we can start by turning that class into something that can be instantiated? 

https://github.com/llvm/llvm-project/pull/70996


More information about the llvm-commits mailing list