[llvm] [SDAG] Prefer forming sign_extend for zext nneg per target preference (PR #70725)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 15:26:32 PDT 2023


https://github.com/nikic approved this pull request.

LGTM

This seems like a reasonable starting point. Something I'm a bit concerned about is that this may break DAGCombiner patterns that look for ZERO_EXTEND. Though given that RISCVCodeGenPrepare already does this replacement aggressively, I guess it's not a big issue in practice.

https://github.com/llvm/llvm-project/pull/70725


More information about the llvm-commits mailing list