[compiler-rt] [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code. (PR #69490)

via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 14:02:51 PDT 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 55c9f24344a49cd1deb86af1d79d4dc3a798c6fb 39b422d9075bc54778800d58b494cc78fe644436 -- compiler-rt/lib/interception/interception_win.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/compiler-rt/lib/interception/interception_win.cpp b/compiler-rt/lib/interception/interception_win.cpp
index 6f1e36adf..f5c93190a 100644
--- a/compiler-rt/lib/interception/interception_win.cpp
+++ b/compiler-rt/lib/interception/interception_win.cpp
@@ -562,17 +562,17 @@ static size_t GetInstructionSize(uptr address, size_t* rel_offset = nullptr) {
       return 9;
     case 0xF2:
       switch (*(u32 *)(address + 1)) {
-          case 0x2444110f:  // f2 0f 11 44 24 XX    movsd   mmword ptr [rsp +
-                            // XX], xmm0
-          case 0x244c110f:  //  f2 0f 11 4c 24 XX       movsd  QWORD PTR
-                            //  [rsp+0x8],xmm1
-          case 0x2454110f:  //  f2 0f 11 54 24 XX       movsd  QWORD PTR
-                            //  [rsp+0x8],xmm2
-          case 0x245c110f:  //  f2 0f 11 5c 24 XX       movsd  QWORD PTR
-                            //  [rsp+0x8],xmm3
-          case 0x2464110f:  //  f2 0f 11 64 24 XX       movsd  QWORD PTR
-                            //  [rsp+0x8],xmm4
-            return 6;
+        case 0x2444110f:  // f2 0f 11 44 24 XX    movsd   mmword ptr [rsp +
+                          // XX], xmm0
+        case 0x244c110f:  //  f2 0f 11 4c 24 XX       movsd  QWORD PTR
+                          //  [rsp+0x8],xmm1
+        case 0x2454110f:  //  f2 0f 11 54 24 XX       movsd  QWORD PTR
+                          //  [rsp+0x8],xmm2
+        case 0x245c110f:  //  f2 0f 11 5c 24 XX       movsd  QWORD PTR
+                          //  [rsp+0x8],xmm3
+        case 0x2464110f:  //  f2 0f 11 64 24 XX       movsd  QWORD PTR
+                          //  [rsp+0x8],xmm4
+          return 6;
       }
       break;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/69490


More information about the llvm-commits mailing list