[llvm] [XCOFF] make related SD symbols as isFunction (PR #69553)

via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 07:12:53 PDT 2023


================
@@ -83,8 +83,30 @@ class SymbolizableObjectFile : public SymbolizableModule {
     // getNameFromSymbolTable.
     uint32_t ELFLocalSymIdx;
 
+    // Both are false if this is not a XCOFF local symbol.
+    bool IsXCOFFSDSymbol;
+    bool IsXCOFFLDSymbol;
----------------
diggerlin wrote:

if I understand correct, you want to priority the symbols which has the same address, can you do something like  https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h#L28 
and 
https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCDisassembler/MCDisassembler.cpp#L85

it will le the Symbolize has the same priority behaviors' as llvm-objdump for xcoff symbols ?

I do not think in XCOFF , when priority the same address symbols, we care about the size of the symbol,  we care about the  `symbol type` and `storage mapping class`. 

https://github.com/llvm/llvm-project/pull/69553


More information about the llvm-commits mailing list