[llvm] LLVM is not needed for chapter two. (PR #69823)

via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 21 02:20:05 PDT 2023


https://github.com/gonsolo created https://github.com/llvm/llvm-project/pull/69823

Since the example is self-contained there is no need to use LLVM.

>From 7a8e793c0017ee98584d1c29bdc511cc878d2899 Mon Sep 17 00:00:00 2001
From: Gon Solo <gonsolo at gmail.com>
Date: Sat, 21 Oct 2023 11:16:07 +0200
Subject: [PATCH] LLVM is not needed for chapter two.

---
 llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst | 7 ++-----
 llvm/examples/Kaleidoscope/Chapter2/CMakeLists.txt        | 4 ----
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst b/llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst
index 47d64cee845d05b..6aec05f29329ae7 100644
--- a/llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst
+++ b/llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst
@@ -716,15 +716,12 @@ Intermediate Representation (IR) from the AST.
 Full Code Listing
 =================
 
-Here is the complete code listing for our running example. Because this
-uses the LLVM libraries, we need to link them in. To do this, we use the
-`llvm-config <https://llvm.org/cmds/llvm-config.html>`_ tool to inform
-our makefile/command line about which options to use:
+Here is the complete code listing for our running example.
 
 .. code-block:: bash
 
     # Compile
-    clang++ -g -O3 toy.cpp `llvm-config --cxxflags`
+    clang++ -g -O3 toy.cpp
     # Run
     ./a.out
 
diff --git a/llvm/examples/Kaleidoscope/Chapter2/CMakeLists.txt b/llvm/examples/Kaleidoscope/Chapter2/CMakeLists.txt
index 563b8cc848f6ed4..237ba5e33616e0f 100644
--- a/llvm/examples/Kaleidoscope/Chapter2/CMakeLists.txt
+++ b/llvm/examples/Kaleidoscope/Chapter2/CMakeLists.txt
@@ -1,7 +1,3 @@
-set(LLVM_LINK_COMPONENTS
-  Support
-  )
-
 add_kaleidoscope_chapter(Kaleidoscope-Ch2
   toy.cpp
   )



More information about the llvm-commits mailing list