[llvm] [LowerSwitch] Don't let pass manager handle the dependency (PR #68662)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 19 10:01:12 PDT 2023


================
@@ -192,6 +191,9 @@ BasicBlock *AMDGPUUnifyDivergentExitNodesImpl::unifyReturnBlockSet(
 bool AMDGPUUnifyDivergentExitNodesImpl::run(Function &F, DominatorTree *DT,
                                             const PostDominatorTree &PDT,
                                             const UniformityInfo &UA) {
+  for (auto &BB : F)
+    assert(hasOnlySimpleTerminator(&BB));
----------------
aeubanks wrote:

should be something like `assert(hasOnlySimpleTerminator(&BB) && "Need to run lower-switch");` so people know what to do if the assert fires

https://github.com/llvm/llvm-project/pull/68662


More information about the llvm-commits mailing list