[llvm] [YAMLParser] Improve plain scalar spec compliance (PR #68946)

Scott Linder via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 09:28:53 PDT 2023


================
@@ -1848,13 +1869,15 @@ bool Scanner::fetchMoreTokens() {
   if (*Current == ',')
     return scanFlowEntry();
 
-  if (*Current == '-' && isBlankOrBreak(Current + 1))
+  if (*Current == '-' && (isBlankOrBreak(Current + 1) || Current + 1 == End))
     return scanBlockEntry();
 
-  if (*Current == '?' && (FlowLevel || isBlankOrBreak(Current + 1)))
+  if (*Current == '?' && (Current + 1 == End || isBlankOrBreak(Current + 1)))
----------------
slinder1 wrote:

I agree it is out of scope, at some point you will be fixing the whole world if you continue. Thank you for expanding the test base for the supported cases, it LGTM!

https://github.com/llvm/llvm-project/pull/68946


More information about the llvm-commits mailing list