[lld] [lld][ELF] Demote symbols in discarded sections to Undefined. (PR #68777)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 14 14:42:22 PDT 2023


================
@@ -3062,6 +3062,31 @@ void LinkerDriver::link(opt::InputArgList &args) {
     script->addOrphanSections();
   }
 
+  // Explicitly demote symbols which didn't get placed. If we don't, any
----------------
MaskRay wrote:

"Explicitly" is redundant.

Suggest: Demote symbols defined relative to input sections that are discarded by /DISCARD/ so that relocations referencing them will get reported.

https://github.com/llvm/llvm-project/pull/68777


More information about the llvm-commits mailing list