[llvm] [llvm-rc] add support for MENUEX (PR #67464)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 04:07:43 PDT 2023


================
@@ -682,6 +691,97 @@ Expected<MenuDefinitionList> RCParser::parseMenuItemsList() {
   return std::move(List);
 }
 
+Expected<MenuDefinitionList> RCParser::parseMenuExItemsList() {
+  RETURN_IF_ERROR(consumeType(Kind::BlockBegin));
+
+  MenuDefinitionList List;
+
+  // Read a set of items. Each item is of one of three kinds:
+  //   MENUITEM caption:String [,[id][, [type][, state]]]]
+  //   POPUP caption:String [,[id][, [type][, [state][, helpID]]]] { popupBody }
+  //   }
----------------
mstorsjo wrote:

This comment feels a bit weirdly written, as there only are two actual member options listed, while `}` or `END` isn't really a member itself. (The comment above in `parseMenuItemsList` doesn't list `}` as one of the options.

https://github.com/llvm/llvm-project/pull/67464


More information about the llvm-commits mailing list