[llvm] [ValueTracking] Use SimplifyQuery in some public APIs (NFC) (PR #68290)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 03:55:08 PDT 2023


================
@@ -39,7 +40,6 @@ struct KnownBits;
 class Loop;
 class LoopInfo;
 class MDNode;
-struct SimplifyQuery;
----------------
nikic wrote:

This is possible, but my thinking here was that (at least after more APIs have been migrated) actually using any ValueTracking functions will need SimplifyQuery.h anyway, so it would be more convenient if ValueTracking.h directly pulls it in, instead of including it in each user.

Including it also allows using the implicit DataLayout -> SimplifyQuery conversion, though I'm not sure how much people use that.

https://github.com/llvm/llvm-project/pull/68290


More information about the llvm-commits mailing list