[llvm] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

Youngsuk Kim via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 18:30:52 PDT 2023


================
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
       CharUnits Align = CGM.getContext().getDeclAlign(VD);
       Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
     }
-    if (Val->getType() != Wrapper->getReturnType())
-      Val = Builder.CreatePointerBitCastOrAddrSpaceCast(
----------------
JOE1994 wrote:

Stripping the call to `CreatePointerBitCastOrAddrSpaceCast` doesn't cause any new `ninja check-clang` failures.

But.. I'm not entirely sure whether stripping the call is justified.

https://github.com/llvm/llvm-project/pull/68277


More information about the llvm-commits mailing list