[compiler-rt] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 11:52:36 PDT 2023


================
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file defines the StringRefOrHashCode class. It is to represent function
+// names in a sample profile, which can be in one of two forms - either a
+// regular string, or a 64-bit hash code.
----------------
MatzeB wrote:

- Should use `/// @file` for documentation about a file so doxygen can pick it up.
- This comment seems wrong ("StringRegOrHashCode" was renamed I guess?). It also seems to mainly repeat what the one class in here is about.

I would suggest to simply remove the file comment (and instead make sure the comment on the class is good).

https://github.com/llvm/llvm-project/pull/66164


More information about the llvm-commits mailing list