[llvm] b225f2d - Fix build failure on windows (NFC)

Jie Fu via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 30 17:07:32 PDT 2023


Author: Jie Fu
Date: 2023-10-01T08:06:34+08:00
New Revision: b225f2d5d737d262c49fece286bba2d3126609e1

URL: https://github.com/llvm/llvm-project/commit/b225f2d5d737d262c49fece286bba2d3126609e1
DIFF: https://github.com/llvm/llvm-project/commit/b225f2d5d737d262c49fece286bba2d3126609e1.diff

LOG: Fix build failure on windows (NFC)

C:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\lib\Object\MachOUniversalWriter.cpp(352) : error C2220: the following warning is treated as an error
C:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\lib\Object\MachOUniversalWriter.cpp(352) : warning C4715: 'llvm::object::writeUniversalBinaryToStream': not all control paths return a value

Added: 
    

Modified: 
    llvm/lib/Object/MachOUniversalWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Object/MachOUniversalWriter.cpp b/llvm/lib/Object/MachOUniversalWriter.cpp
index ea01e27b7f76075..997235f0b74167a 100644
--- a/llvm/lib/Object/MachOUniversalWriter.cpp
+++ b/llvm/lib/Object/MachOUniversalWriter.cpp
@@ -349,6 +349,8 @@ Error object::writeUniversalBinaryToStream(ArrayRef<Slice> Slices,
     return writeUniversalArchsToStream<MachO::fat_arch>(FatHeader, Slices, Out);
     break;
   }
+
+  llvm_unreachable("Invalid fat header type");
 }
 
 Error object::writeUniversalBinary(ArrayRef<Slice> Slices,


        


More information about the llvm-commits mailing list