[PATCH] D155431: [CMake] Clean up old code for handling MSVC runtime setting the old way

Thu Sep 28 06:48:16 PDT 2023

mstorsjo added a comment.

In D155431#4651689 <https://reviews.llvm.org/D155431#4651689>, @yurybura wrote:

>>>> Are you saying that this gets added automatically by CMake in this variable, or that it is set manually by your build configuration? I don't think it's added automatically by CMake.
>>>
>>> I'm saying that VCPKG adds these compiler flags.
>>
>> And I'm saying that it's redundant.
>
> Yes, it is. I'm just asking to save removing these flags for backward compatibility.

Right.

I'd be ok with restoring the removing of these flags temporarily (for a little while in git main, and backporting that to the 17.x release branch), but going forward, in an environment set up according to https://cmake.org/cmake/help/latest/policy/CMP0091.html, I think the user shouldn't be adding these flags manually.

Unfortunately, while we can keep this cleanup in 17.x, users of such setups won't necessarily get visible deprecation warnings telling them to move forward with their setups though. (Or I guess we could add similar logic scanning the variables and giving a warning if they are set there?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155431/new/

https://reviews.llvm.org/D155431