[PATCH] D159140: [GlobalISel] LegalizationArtifactCombiner: Elide redundant G_AND

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 15:30:10 PDT 2023


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

In D159140#4651531 <https://reviews.llvm.org/D159140#4651531>, @tobias-stadler wrote:

> @arsenm @aemerson Hi, do you have any further comments on this or are you ok with this change?

I think the benefits outweigh the costs in this case. I would just put a comment in the code explaining exactly why this combine is there, since someone may try to remove it in future if they don't notice any impact on final codegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159140/new/

https://reviews.llvm.org/D159140



More information about the llvm-commits mailing list