[PATCH] D159537: [AArch64] Don't rely on (zext (trunc x)) pattern to detect zext_inreg MULL patterns - use value tracking directly

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 10:39:39 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4436
 
-  assert(N->getOpcode() == ISD::BUILD_VECTOR && "expected BUILD_VECTOR");
-  EVT VT = N->getValueType(0);
+  if (VT.is128BitVector()) {
+    APInt HiBits = APInt::getHighBitsSet(OrigEltSize, EltSize);
----------------
dmgreen wrote:
> I believe this should always be a 128bit vector at this point.
Thanks, I'll make it an assert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159537/new/

https://reviews.llvm.org/D159537



More information about the llvm-commits mailing list