[PATCH] D155987: AMDGPU: Move placement of RemoveIncompatibleFunctions

[Jakub Chlanda via Phabricator via llvm-commits]

jchlanda added a subscriber: arsen.
jchlanda added a comment.

Hi @arsen 
Apologies for a late reply, this should teach me not to post a day before my holidays.

> But __ocml_tanh_f32 doesn't use a dot intrinsic? Not sure how or where you would be seeing that. ocml is currently free of subtarget feature dependence



> The inliner should not be able to fix your code. If this is deleting the function, then it shouldn't have been an inlining candidate in the first place. Something is failing to consider the incompatible feature.

This was exactly the problem with our implementation, we had assumptions with regards to the target embedded in the libclc bitcode that were not portable across architectures. Thank you very much for your help, much appreciated!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155987/new/

https://reviews.llvm.org/D155987