[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Wed Sep 20 23:59:13 PDT 2023

phosek added a comment.

Would it be possible to split up the LLVM changes into another change so we can land it separately from the Clang support?

================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:337

-  bool isTargetWin64() const { return Is64Bit && isOSWindows(); }
+  bool isTargetWin64() const {
+    return Is64Bit && (isOSWindows() || TargetTriple.isUEFI());
----------------
It's a bit strange for this method to return true even for UEFI which is not Windows. I think it'd be clear to introduce a new method `isTargetUEFI()` and modify relevant callsites to use `isTargetWin64() || isTargetUEFI()`. Ideally that would be done as a separate patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152206/new/

https://reviews.llvm.org/D152206