[PATCH] D157961: [llvm][utils] Fix SmallVector formatter when type is a pointer

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 14:26:24 PDT 2023


dblaikie added a comment.
Herald added a subscriber: sunshaoce.

Hmm - it seems weird that the formatter for SmallVector would be involved directly in the formatting of SmallVector*? Could we fix that, so the SmallVector formatter is only used for SmallVector objects, not pointers? (if lldb wants to automatically dereference pointers and print the result - that's a generic feature in lldb that the SmallVector pretty printer wouldn't need to know about?)

(like what does lldb do with `int*`? Does it print the int (if any) that's pointed to?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157961/new/

https://reviews.llvm.org/D157961



More information about the llvm-commits mailing list