[PATCH] D157669: Fix spurious errors that would be emitted when DW_TAG_subprogram DIEs had mutliple ranges in DW_AT_ranges.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 14:23:59 PDT 2023


dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp:212
+  for (const DWARFAddressRange &DwarfRange : DwarfRanges) {
+    if (DwarfRange.LowPC < DwarfRange.HighPC)
+      Ranges.insert({DwarfRange.LowPC, DwarfRange.HighPC});
----------------
We've got a utility for checking for tombstones, perhaps that should be used here? (I guess this check is essentially for detecting tombstoned ranges?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157669/new/

https://reviews.llvm.org/D157669



More information about the llvm-commits mailing list