[PATCH] D158579: [AMDGPU] Add DAG ISel support for preloaded kernel arguments

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.h:158
+  // Map the index of preloaded kernel arguments to its descriptor.
+  SmallDenseMap<int, KernArgPreloadDescriptor> PreloadKernArgs{};
+
----------------
arsenm wrote:
> Why is it a map? Isn't this just an array?
We would at least need an offset stored somewhere since we shouldn't assume preloads will always start at the first kernel argument.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:848
+  MCStreamer &OS = getStreamer();
+  for (int i = 0; i < 64; ++i) {
+    OS.emitInt32(Encoded_s_nop);
----------------
arsenm wrote:
> emitValueToAlignment?
I'm not sure how relevant the alignment is here actually. What matters is that we are emitting exactly 256 bytes. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158579/new/

https://reviews.llvm.org/D158579